Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #136

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Code cleanup #136

merged 7 commits into from
Oct 4, 2024

Commits on Sep 14, 2024

  1. correct devtools::document() issues

    - export S3 methods, even if corresponding generic is not exported
    - document the sentinel "_PACKAGE" rather than using @doctype
    mtmorgan committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    26f60d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. address devtools::test() errors and verbosity

    - two tests fail because the length of the return value has changed (from
      17 to 18 list elements)
    
      - hard to know how the return value has changed -- simple additiion? of
        which element? etc
      - assume the change does not break code
      - make more robust by checking for set equality of current and returned
        names
    
    - reduce messages from `readr::read_csv()` by providing
      `col_classes = FALSE` argument
    - silence progress in test-search.R by adding `verbose = TRUE`
    mtmorgan committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    8e92576 View commit details
    Browse the repository at this point in the history
  2. update print.dataverse_dataset()

    - 'license' is now a list; print the 'name'
    - 'length(x$files)` is incorrect for a data.frame, use `NROW()`
    mtmorgan committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    fe86c78 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Fix a missing quote (typo). Also simplify example for dataset argumen…

    …t -- the"doi:" prefix is not necessary
    kuriwaki committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    14a082d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. update print.dataverse_dataset()

    - handle previous as well as current 'License' format
    mtmorgan committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d80f081 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    14a1f93 View commit details
    Browse the repository at this point in the history
  2. Update test to contain new attribute

    Also no need to setequal
    kuriwaki authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b73fab9 View commit details
    Browse the repository at this point in the history