Performance improvement for CoTeDe #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DummyCNV was moved into wodpy as Wod4CoTeDe with few improvements.
Adding .datetime(), .z_level_qc() & .t_level_qc()
Before it was always running a full block of tests, to get the results of a single test
CoTeDe now try to run the minimum ammount of tests required, so it is not required anymore to explicitly define setup with a dictionary.
There was a conceptual error before. It should be faster now.
|
@s-good and @BillMills , are you OK with this PR? It says that there is a conflict, but I can't see what it is. |
|
@castelao if you on your local machine switch to your |
|
Hi @BillMills . Yes, I called upstream, and yes I usually keep them sync, like I did for the previous PR Thanks, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it would call CoTeDe to run a full set of tests, like the full GTSPP recommendation, to extract only one test at a time. Now it calls CoTeDe to run only the specific test of interest.
It should make significant performance difference for most tests using CoTeDe. Since AutoQC runs in parallel, and only a portion of tests use CoTeDe, it requires a large data processing to identify this time difference.