test

src/asm/output.cpp

@@ -492,7 +492,7 @@ static bool dumpMacros(FILE *file) {
 void out_WriteState(std::string name, std::vector<StateFeature> const &features) {
 	FILE *file;
 	if (name != "-") {
-		file = fopen(name.c_str(), "w");
+		file = fopen(name.c_str(), "wb");
 	} else {
 		name = "<stdout>";
 		file = fdopen(STDOUT_FILENO, "w");

test/asm/test.sh

@@ -5,6 +5,19 @@ export LC_ALL=C
 # Game Boy release date, 1989-04-21T12:34:56Z (for reproducible test results)
 export SOURCE_DATE_EPOCH=609165296
 
+# On Windows, the paths returned by `mktemp` are Unix paths, whereas RGBDS expects Windows paths.
+# Bash implicitly translates them when recognised, but this breaks if the path is prefixed
+# (at-files, state file spec, etc.); thus, return an absolute path instead.
+w32_path() {
+	set -x
+	if which cygpath 2>/dev/null; then
+		cygpath -w "$1"
+	else
+		printf '%s\n' "$1"
+	fi
+	set +x
+}
+
 o="$(mktemp)"
 gb="$(mktemp)"
 input="$(mktemp)"
@@ -132,7 +145,7 @@ done
 # These tests do their own thing
 
 i="state-file"
-RGBASMFLAGS="-Weverything -s all:$o"
+RGBASMFLAGS="-Weverything -s all:$(w32_path "$o")"
 for variant in '' '.pipe'; do
 	(( tests++ ))
 	echo "${bold}${green}${i%.asm}${variant}...${rescolors}${resbold}"