Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.5.0 (beta): adds get_job_output_logfile and updates doc #27

Merged
merged 34 commits into from
Oct 19, 2022
Merged

v0.5.0 (beta): adds get_job_output_logfile and updates doc #27

merged 34 commits into from
Oct 19, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 30, 2022 •
edited
Loading

What do these changes do?

  • OAS 0.4.0 adds get_job_output_logfile
  • client API bumps version to 0.5.0
  • 📝 updated BasicTutorial.md with log example
  • 🔨 moves API generator script to this repo
  • 🔨 enhanced Makefile
  • code formatted with black

Related issue/s

How to test

$ pip install git+https://github.com/ITISFoundation/osparc-simcore-python-client.git@v0.5.0
$ python -c "import osparc; print(osparc.__version__)"
0.5.0

can then run tutorial BasicTutorial.ipynb

Checklist

@pcrespov pcrespov self-assigned this May 30, 2022
@pcrespov pcrespov changed the title WIP: V0.5.0 v0.5.0 (beta): adds get_job_output_logfile and updates doc May 31, 2022
@pcrespov pcrespov added documentation Improvements or additions to documentation enhancement New feature or request labels May 31, 2022
@pcrespov pcrespov marked this pull request as ready for review May 31, 2022 12:07
@pcrespov pcrespov requested review from elisabettai, sanderegg, colinRawlings and mguidon and removed request for sanderegg May 31, 2022 12:08
@pcrespov pcrespov added this to the Croissant milestone May 31, 2022
@pcrespov pcrespov mentioned this pull request Jun 3, 2022
Closed
@pcrespov pcrespov mentioned this pull request Oct 13, 2022
Closed
@pcrespov pcrespov requested a review from mguidon October 19, 2022 11:33
@pcrespov pcrespov merged commit 5354c7f into master Oct 19, 2022
elisabettai
elisabettai approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

Just a minor note on the BasicTutorial, we would need to update where it mentions "Discover Tab" to reflect the new UI.

@pcrespov pcrespov deleted the v0.5.0 branch October 19, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabettai elisabettai elisabettai approved these changes

@mguidon mguidon mguidon approved these changes

Assignees

@pcrespov pcrespov

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Croissant
Development

Successfully merging this pull request may close these issues.
4 participants
@pcrespov @elisabettai @mguidon @KZzizzle