Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️📝 API-server files collection cleanup and doc #4645

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 23, 2023

What do these changes do?

Minor cleanup and doc of files collections in the api-server:

  • ♻️ cleanup API's files collection
  • ♻️ updates openapi specs
  • 📝 doc
    • controller-service-repository (CSR) pattern
    • @bisgaard-itis I added some doc about files collection to 4641 so you can follow up on those.
  • ♻️ renames some utils modules as services to follow CSR pattern

Related issue/s

How to test

in-place

DevOps

None

@pcrespov pcrespov changed the title ♻️📝 Is4604/api server review ♻️📝 API-server files collection cleanup and doc Aug 23, 2023
@pcrespov pcrespov self-assigned this Aug 23, 2023
@pcrespov pcrespov added the a:apiserver api-server service label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4645 (38959d5) into master (08e7c25) will decrease coverage by 18.5%.
The diff coverage is 89.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4645      +/-   ##
=========================================
- Coverage    85.2%   66.7%   -18.5%     
=========================================
  Files        1054     513     -541     
  Lines       44715   25602   -19113     
  Branches     1018     190     -828     
=========================================
- Hits        38107   17090   -21017     
- Misses       6379    8465    +2086     
+ Partials      229      47     -182     
Flag Coverage Δ
integrationtests 65.4% <ø> (-0.1%) ⬇️
unittests 81.7% <89.7%> (-2.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._service_api_server/services/solver_job_outputs.py 56.0% <ø> (ø)
...src/simcore_service_api_server/api/routes/files.py 61.6% <86.6%> (-1.4%) ⬇️
...core_service_api_server/api/routes/solvers_jobs.py 76.1% <100.0%> (ø)
...simcore_service_api_server/models/schemas/files.py 92.7% <100.0%> (ø)
...pi_server/services/solver_job_models_converters.py 97.1% <100.0%> (ø)
...src/simcore_service_api_server/services/storage.py 60.0% <100.0%> (ø)

... and 790 files with indirect coverage changes

@pcrespov pcrespov enabled auto-merge (squash) August 23, 2023 07:54
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 38959d5 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good links in the updated docs :--)

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the clean up

@pcrespov pcrespov disabled auto-merge August 23, 2023 12:35
@pcrespov pcrespov merged commit c0db38f into ITISFoundation:master Aug 23, 2023
51 checks passed
@pcrespov pcrespov deleted the is4604/api-server-review branch August 23, 2023 12:36
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants