Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Implement delete file endpoint #4707

Merged
merged 62 commits into from
Sep 6, 2023
Merged

✨Implement delete file endpoint #4707

merged 62 commits into from
Sep 6, 2023

Conversation

bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Implements delete endpoint for the files section of the public API
  • Ensures only relative links are returned from get_upload_links endpoint.
  • Change name of ClientUploadSchema to ensure it doesn't have the word "Schema" in it
  • Improves on the capture mechanism for semi-automatically generating mock data for the "back-end" of the public API.

Related issue/s

How to test

DevOps Checklist

@bisgaard-itis
use relative paths in links returned from get_upload_links
3afd5ea
@bisgaard-itis
initial implementation of deletion endpoint
b58ec4a
@bisgaard-itis
further additions to delete endpoint
8885ee3
@bisgaard-itis
add user_id automatically in abort/complete endpoints
1482a2b
@bisgaard-itis
use storage_client for delete entrypoint
232a9c9
@bisgaard-itis
add mock data and massage endpoints a bit
5723e5f
@bisgaard-itis
add openapi-core to test tools
f27b668
@bisgaard-itis
begin to process captures using openapi specs
e33e599
@bisgaard-itis
merge master into implement-delete-endpoint
607cefc
@bisgaard-itis
add jsonref as a dependency
7bf74fd
@bisgaard-itis
refactoring
867188f
@bisgaard-itis
make sure jsonref is available for tests
839e812
@bisgaard-itis
start adding test cases for different types
34d538f
@bisgaard-itis
start adding more serious tests
2dfbc60
@bisgaard-itis
further changes to support regex patterns
4916492
@bisgaard-itis
add a few more tests and minor bugfix
897d520
@bisgaard-itis
several small changes to improve logging
bac96a1
@bisgaard-itis
add catalog to hosts
ee81cfe
@bisgaard-itis
initial implementation of pytest fixture which makes use of the captures
ea4c1c5
@bisgaard-itis
minor change
cb45edd
@bisgaard-itis
fix several minor issues
8e3b369
@bisgaard-itis
several changes to make tests work
94de7ed
@bisgaard-itis
several changes to make test pass
8421786
@bisgaard-itis
several small changes
b34ea5a
@bisgaard-itis
merge master into implement-delete-file-endpoint
b384f48
@bisgaard-itis bisgaard-itis self-assigned this Sep 4, 2023
@bisgaard-itis bisgaard-itis added the t:enhancement Improvement or request on an existing feature label Sep 4, 2023
bisgaard-itis and others added 24 commits September 5, 2023 14:15
@bisgaard-itis
checkout .txt requirements
4acb51a
@bisgaard-itis
update aioresponses
a84b0e7
@bisgaard-itis
abortion_url -> abort_url
a5b4b21
@bisgaard-itis
only specify path in client request
47481b8
@bisgaard-itis
fix call to logger
ca81388
@bisgaard-itis
small changes to enhance preprocessing call
e4bd1c1
@bisgaard-itis
resolve name collisions
ea75aa0
@bisgaard-itis
further minor changes
01f79e9
@bisgaard-itis
further minor changes
e735dbd
@bisgaard-itis
changes to capture callback
817eea9
@bisgaard-itis
remove markit
a4c86ce
@bisgaard-itis
fix import
4d3bd7e
@bisgaard-itis
refix
54fb7c7
@bisgaard-itis
small change
290cf1b
@bisgaard-itis
Merge branch 'master' into implement-delete-file-endpoint
bf804f8
@bisgaard-itis
Merge branch 'master' into implement-delete-file-endpoint
416224f
@bisgaard-itis
Merge branch 'master' into implement-delete-file-endpoint
8167280
@bisgaard-itis
Merge branch 'master' into implement-delete-file-endpoint
1a31ea7
@bisgaard-itis
move jsonref to base res
b271478
@bisgaard-itis
regenerate reqs
e581999
@bisgaard-itis
attempt to only import jsonref in testing mode
96025a4
@bisgaard-itis
small correction
410ac46
@bisgaard-itis
move another import
4fe1bb2
@bisgaard-itis
yet another minor fix
49fc3fe
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 6, 2023

Code Climate has analyzed commit 49fc3fe and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis merged commit 100492f into ITISFoundation:master Sep 6, 2023
54 checks passed
@bisgaard-itis bisgaard-itis deleted the implement-delete-file-endpoint branch September 6, 2023 11:26
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 13, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate CodeClimate left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@bisgaard-itis bisgaard-itis

Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Baklava
Development

Successfully merging this pull request may close these issues.
3 participants
@bisgaard-itis @pcrespov @sanderegg