-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUR and local builds #17
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Luiz Oliveira <[email protected]>
Signed-off-by: Luiz Oliveira <[email protected]>
You guys(@vovimayhem @thelastinuit) can you take a look at this, seems like a good contribution! Thanks for it by the way @Ziul |
WOW!!! AUR!! it's been a long time I don't use it :( gotta go back! |
@Ziul The best practice in the go universe says that relative path are not the go way. Every package should have a unique import path and be imported everywhere using that same import path. |
@thelastinuit That was something that really bothered me. The great motive for this PR was to include the |
I think, take it with a grain of salt, there is a way with the latest updates but I'm not sure. |
Sure! |
Finally had some time to prioritize thing a bit around, and reviewing this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @Ziul ! Sorry for the delayed response - I owe you a couple of beers.
Looks to me your'e trying to address two problems in this PR:
-
How it is published (and installed) using the Arch Linux's package manager (AUR): We've been suggested on Feature Request: Make a Snap package #13 to use a tool called snapcraft which we may (or may not) use to publish the binaries through a bunch of package managers - included Arch Linux's. Still, there's no code provided addressing building and/or publishing the AUR package in this PR - maybe you published it there for us?
-
How we build the
plis
binary locally: This wasn't meant as a way to useplis
, but actually for us to developplis
. Those changes look interesting, and I'm still investigating how these changes affect our development process.
In the end, to accept this PR I need to keep the changes of using AUR out, as we need to discuss those changes in another PR.
``` | ||
yaourt -S plis | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How it it that it's installed using yaourt
? Who's keeping the AUR repository up to date?
...specially since #13 is still an [open and ongoing discussion](#13 (comment). |
What does this PR do?
README.md
with info about how to install the package using AURAfter the PR be accepted, it's possible to create a version on AUR that use the git version, plus the release version