fixed get_news()

Iceloof · Nov 30, 2023 · 044c1db · 044c1db
1 parent 4fdb2be
commit 044c1db
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/GoogleNews/__init__.py b/GoogleNews/__init__.py
@@ -82,7 +82,7 @@ def __init__(self,lang="en",period="",start="",end="",encode="utf-8",region=None
         self.__end = end
         self.__encode = encode
         self.__exception = False
-        self.__version = '1.6.10'
+        self.__version = '1.6.11'
 
     def getVersion(self):
         return self.__version
@@ -282,7 +282,7 @@ def get_news(self, key="",deamplify=False):
                 try:
                     # title
                     try:
-                        title=article.find('h3').text
+                        title=article.find('h4').text
                     except:
                         title=None
                     # description
@@ -305,19 +305,23 @@ def get_news(self, key="",deamplify=False):
                     # link
                     if deamplify:
                         try:
-                            link = 'news.google.com/' + article.find("h3").find("a").get("href")
+                            link = 'news.google.com/' + article.find("h4").parent.get("href")[2:]
                         except Exception as deamp_e:
                             print(deamp_e)
                             link = article.find("article").get("jslog").split('2:')[1].split(';')[0]
                     else:
-                            link = 'news.google.com/' + article.find("h3").find("a").get("href")
+                        try:
+                            link = 'news.google.com/' + article.find("h4").parent.get("href")[2:]
+                        except Exception as deamp_e:
+                            print(deamp_e)
+                            link = None
                     self.__texts.append(title)
                     self.__links.append(link)
                     if link.startswith('https://www.youtube.com/watch?v='):
                         desc = 'video'
                     # image
                     try:
-                        img = article.find("img").get("src")
+                        img = article.find("figure").find("img").get("src")
                     except:
                         img = None
                     # site
@@ -326,7 +330,7 @@ def get_news(self, key="",deamplify=False):
                     except:
                         site=None
                     try:
-                        media=article.find("div").find("a").text
+                        media=article.find("div").findAll("div")[1].find("div").find("div").find("div").text
                     except:
                         media=None
                     # collection

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="GoogleNews",
-    version="1.6.10",
+    version="1.6.11",
     author="Hurin Hu",
     author_email="[email protected]",
     description="Google News search for Python",

diff --git a/test/test_search.py b/test/test_search.py
@@ -51,7 +51,7 @@ class TestStringMethods(unittest.TestCase):
 
   def testVersion(self):
     googlenews = GoogleNews()
-    version = '1.6.10'
+    version = '1.6.11'
     self.assertIn(version, googlenews.getVersion())
     print('Latest version matched')