Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objectpacker: Assure gosec that in.Len() to uint64 cannot overflow #74

Merged
merged 1 commit into from
Oct 7, 2024
Merged

objectpacker: Assure gosec that in.Len() to uint64 cannot overflow #74

merged 1 commit into from
Oct 7, 2024

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 4, 2024

objectpacker/objectpacker.go:91:55: G115: integer overflow conversion int -> uint64 (gosec)
if err := binary.Write(out, binary.BigEndian, uint64(l)); err != nil {

@oxzi
objectpacker: Assure gosec that in.Len() to uint64 cannot overflow
ef4abc3 
> objectpacker/objectpacker.go:91:55: G115: integer overflow conversion int -> uint64 (gosec)
>                 if err := binary.Write(out, binary.BigEndian, uint64(l)); err != nil {
@oxzi oxzi requested a review from lippserd October 4, 2024 09:09
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 4, 2024
@lippserd lippserd merged commit a9fcd1b into main Oct 7, 2024
15 checks passed
@lippserd lippserd deleted the objectpacker-gosec-nolint branch October 7, 2024 11:30
@oxzi oxzi added this to the 0.4.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd lippserd approved these changes

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oxzi @lippserd