Load config from both env and yaml #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
config-from-env
branch
from
6d9ce31 to
d6335e5
Compare
lippserd
requested changes
Jan 15, 2025
cmd/icinga-kubernetes/main.go
Outdated
|
|
||
| if err = config.Load(&cfg, config.LoadOptions{ | ||
| Flags: glue, | ||
| EnvOptions: config.EnvOptions{Prefix: "IFK_"}, |
There was a problem hiding this comment.
Although there is (much) more to type, ICINGA_FOR_KUBERNETES_ simply reads much better than IFK.
lippserd
reviewed
Jan 16, 2025
cmd/icinga-kubernetes/main.go
Outdated
| pflag.StringVar( | ||
| &glue.Config, | ||
| "config", | ||
| daemon.DefaultConfigPath, |
There was a problem hiding this comment.
A default shouldn't be set, right? Else f.Config != "" is never false.
jrauh01
force-pushed
the
config-from-env
branch
from
93c8e25 to
a5ec519
Compare
lippserd
requested changes
Jan 20, 2025
pkg/daemon/config.go
Outdated
| @@ -7,12 +7,16 @@ import ( | |||
| "github.com/icinga/icinga-kubernetes/pkg/notifications" | |||
| ) | |||
|
|
|||
| // DefaultConfigPath specifies the default location of Icinga DB's config.yml for package installations. | |||
There was a problem hiding this comment.
Everything about this sentence is wrong 😆
pkg/daemon/config.go
Outdated
| @@ -7,12 +7,16 @@ import ( | |||
| "github.com/icinga/icinga-kubernetes/pkg/notifications" | |||
| ) | |||
|
|
|||
| // DefaultConfigPath specifies the default location of Icinga DB's config.yml for package installations. | |||
| // const DefaultConfigPath = "/etc/icinga-kubernetes/config.yml" | |||
Default gets returned in ConfigFlagGlue.GetConfigPath() if config is not explicitly set.
jrauh01
force-pushed
the
config-from-env
branch
from
a8abe6a to
e919743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR Icinga for Kubernetes supports configuration loading in three scenarios:
The configuration is loaded via
config.Load()Requires Icinga/icinga-go-library#87
Closes #160