ContactListItem: Drop channel indicator (#285)

resolves #266
Icinga · Feb 26, 2025 · 364c47d · 364c47d
2 parents fb6b06c + dc42339
commit 364c47d
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 110 deletions.
diff --git a/application/controllers/ContactsController.php b/application/controllers/ContactsController.php
@@ -19,7 +19,6 @@
 use ipl\Web\Control\LimitControl;
 use ipl\Web\Control\SortControl;
 use ipl\Web\Filter\QueryString;
-use ipl\Web\Url;
 use ipl\Web\Widget\ButtonLink;
 use ipl\Html\ValidHtml;
 
@@ -42,8 +41,7 @@ public function init()
 
     public function indexAction()
     {
-        $contacts = Contact::on($this->db)
-            ->withColumns('has_email');
+        $contacts = Contact::on($this->db);
 
         $limitControl = $this->createLimitControl();
         $paginationControl = $this->createPaginationControl($contacts);

diff --git a/library/Notifications/Model/Behavior/HasAddress.php b/library/Notifications/Model/Behavior/HasAddress.php
diff --git a/library/Notifications/Model/Contact.php b/library/Notifications/Model/Contact.php
@@ -6,7 +6,6 @@
 
 use DateTime;
 use ipl\Orm\Behavior\BoolCast;
-use Icinga\Module\Notifications\Model\Behavior\HasAddress;
 use ipl\Orm\Behavior\MillisecondTimestamp;
 use ipl\Orm\Behaviors;
 use ipl\Orm\Model;
@@ -70,7 +69,6 @@ public function getSearchColumns(): array
 
     public function createBehaviors(Behaviors $behaviors): void
     {
-        $behaviors->add(new HasAddress());
         $behaviors->add(new MillisecondTimestamp(['changed_at']));
         $behaviors->add(new BoolCast(['deleted']));
     }

diff --git a/library/Notifications/Widget/ItemList/ContactListItem.php b/library/Notifications/Widget/ItemList/ContactListItem.php
@@ -11,7 +11,6 @@
 use ipl\Html\Text;
 use ipl\Web\Common\BaseListItem;
 use ipl\Web\Url;
-use ipl\Web\Widget\Icon;
 use ipl\Web\Widget\Link;
 
 /**
@@ -40,17 +39,6 @@ protected function assembleVisual(BaseHtmlElement $visual): void
         ));
     }
 
-    protected function assembleFooter(BaseHtmlElement $footer): void
-    {
-        $contactIcons = new HtmlElement('div', Attributes::create(['class' => 'contact-icons']));
-
-        if (isset($this->item->has_email) && $this->item->has_email) {
-            $contactIcons->addHtml(new Icon('at'));
-        }
-
-        $footer->addHtml($contactIcons);
-    }
-
     protected function assembleTitle(BaseHtmlElement $title): void
     {
         $title->addHtml(new Link(