Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unique constraints consistent across databases #2895

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

raviks789
Copy link
Collaborator

@raviks789 raviks789 commented Jul 22, 2024

Unique constraints import_row_modifier_prio and service_branch_object_name are only present in PostgreSQL and not in MySQL. But the constraints needs to be consistent across databases.

fixes #2270

@raviks789 raviks789 requested a review from nilmerg July 22, 2024 13:48
@raviks789 raviks789 self-assigned this Jul 22, 2024
@cla-bot cla-bot bot added the cla/signed label Jul 22, 2024
@raviks789 raviks789 changed the title PostgreSQL: Make unique constraints consistent across databases Make unique constraints consistent across databases Jul 22, 2024
@raviks789 raviks789 added this to the v1.11.2 milestone Aug 13, 2024
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do they differ to begin with? (7c18c0b)
Because: b9aea20
And: #1187 (comment)

So, what works for MySQL users since 7 years, should now also work for PostgreSQL users.

@nilmerg nilmerg merged commit 853b6ce into master Aug 15, 2024
8 of 15 checks passed
@nilmerg nilmerg deleted the fix/consistent-uniqueness-across-databases branch August 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while changing priority of the Import Source Modifier
2 participants