Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup according to best practices. #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

coredeveloper
Copy link

  • import package:example replaced with proper references.
  • Scaffold.of(context, nullOk: true) used instead of unsupported Scaffold.maybeOf(context)

Artem Panfilov added 2 commits February 6, 2021 09:55
- import package:example replaced with proper references.
- Scaffold.of(context, nullOk: true) used instead of unsupported Scaffold.maybeOf(context)
- minor math optimisation
- removed unused vars
Copy link
Collaborator

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks like a minor but good improvement to me. Could you please rebase to the latest commit and also update the pubspec/changelog?

Thank you.

@miguelpruivo miguelpruivo self-assigned this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants