Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint with ruff #163

Merged
merged 32 commits into from
Sep 9, 2024
Merged

Lint with ruff #163

merged 32 commits into from
Sep 9, 2024

Conversation

jschlyter
Copy link
Collaborator

@jschlyter jschlyter commented May 29, 2024

Lots of small fixed to please ruff. All of them makes sense and helps us write better code.

closes #162

@jschlyter jschlyter marked this pull request as draft May 30, 2024 08:36
@jschlyter
Copy link
Collaborator Author

WIP, ping @rohe for a heads up

@jschlyter jschlyter marked this pull request as ready for review June 7, 2024 09:53
@jschlyter jschlyter requested review from a team and removed request for a team June 7, 2024 09:53
@jschlyter jschlyter requested review from rohe and a team June 7, 2024 09:53
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 58.84956% with 93 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (f94b929) to head (16ffca5).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/cryptojwt/key_bundle.py 50.00% 11 Missing and 1 partial ⚠️
src/cryptojwt/tools/jwtpeek.py 0.00% 11 Missing ⚠️
src/cryptojwt/jwk/okp.py 0.00% 8 Missing ⚠️
src/cryptojwt/jwk/ec.py 16.66% 5 Missing ⚠️
src/cryptojwt/jws/jws.py 72.22% 5 Missing ⚠️
src/cryptojwt/jwe/jwe_ec.py 63.63% 4 Missing ⚠️
src/cryptojwt/jwk/hmac.py 33.33% 4 Missing ⚠️
src/cryptojwt/key_jar.py 75.00% 3 Missing and 1 partial ⚠️
src/cryptojwt/jwk/x509.py 0.00% 3 Missing ⚠️
src/cryptojwt/jws/dsa.py 0.00% 3 Missing ⚠️
... and 20 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files          44       44           
  Lines        4634     4634           
  Branches      993      993           
=======================================
  Hits         3551     3551           
  Misses        788      788           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschlyter
Copy link
Collaborator Author

ping @rohe

@jschlyter jschlyter merged commit ce07798 into IdentityPython:main Sep 9, 2024
9 of 10 checks passed
@jschlyter jschlyter deleted the ruff branch September 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint with Ruff
2 participants