Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Document EGL exported images #187

Merged
merged 1 commit into from
Mar 13, 2024
Merged

doc: Document EGL exported images #187

merged 1 commit into from
Mar 13, 2024

Conversation

aperezdc
Copy link
Member

...because some documentation is always better than no documentation.

@aperezdc aperezdc added the enhancement New feature or request label Mar 13, 2024
@aperezdc aperezdc self-assigned this Mar 13, 2024
TingPing
TingPing approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the default for the arguments is (transfer none), but seems fine.

@aperezdc
Copy link
Member Author

I believe the default for the arguments is (transfer none), but seems fine.

Double checked, and yes you are right. I always forget what's the default so I lean towards being explicit which does no harm 😉

Thanks!

@aperezdc aperezdc merged commit 0b35394 into master Mar 13, 2024
2 checks passed
@aperezdc aperezdc deleted the aperezdc/docs-exported-image branch March 13, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingPing TingPing TingPing approved these changes

@alexgcastro alexgcastro Awaiting requested review from alexgcastro

@carlosgcampos carlosgcampos Awaiting requested review from carlosgcampos

Assignees

@aperezdc aperezdc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperezdc @TingPing