Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(calendar): scope themes to the component (initial commit, no extra improvements) #15373

Open
wants to merge 20 commits into
base: simeonoff/scoped-styles
Choose a base branch
from

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Feb 14, 2025

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

…nt (initial commit, no extra improvements)

revert the variables file to material light
@desig9stein desig9stein marked this pull request as ready for review February 21, 2025 08:28
@desig9stein desig9stein added the ❌ status: awaiting-test PRs awaiting manual verification label Feb 21, 2025
@simeonoff simeonoff assigned adrianptrv and unassigned simeonoff Feb 21, 2025
@adrianptrv
Copy link

When we start selecting a date range and hover over the second date, any 'outside dates' within the range are highlighted with a solid color, instead of staying gray like they should.

This issue also appears on the master branch.

Screenshot 2025-02-25 at 17 53 51

However, on Web Components, the 'outside dates' color remains gray.

Screenshot 2025-02-25 at 17 52 37

…opov/scoped-styles/calendar

# Conflicts:
#	projects/igniteui-angular/src/lib/calendar/calendar.component.html
#	projects/igniteui-angular/src/lib/calendar/calendar.component.ts
#	projects/igniteui-angular/src/lib/calendar/days-view/days-view.component.html
#	projects/igniteui-angular/src/lib/calendar/months-view/months-view.component.ts
#	projects/igniteui-angular/src/lib/calendar/years-view/years-view.component.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Calendar]: Bundle theme styles to component
3 participants