feat(progress): update linear progres props and add variants for circular #15385
Conversation
|
@didimmova Modifying the |
| $progress-circle-color-start: map.get($theme, 'progress-circle-color'); | ||
| $progress-circle-color-end: map.get($theme, 'progress-circle-color'); | ||
| $fill-color-default-start: map.get($theme, 'fill-color-default'); | ||
| $fill-color-default-end: map.get($theme, 'fill-color-default'); |
There was a problem hiding this comment.
I'm not sure if renaming progress-circle-color-start is the best approach, as it now gives the impression that I have variables, such as fill-color-info-start, which do not exist.
| } | ||
|
|
||
| @return extend($theme, ( | ||
| name: $name, | ||
| base-circle-color: $base-circle-color, | ||
| progress-circle-color-start: $progress-circle-color-start, | ||
| progress-circle-color-end: $progress-circle-color-end, | ||
| fill-color-default-start: $fill-color-default-start, |
There was a problem hiding this comment.
The fill-color-default should also be here, otherwise the user can't use it
There was a problem hiding this comment.
I don't think the user uses it anyway, as in the beginning it's separated into two colors which form a gradient, no matter if it's one or two colors so the progress-circle-color(before) itself never gets used in the theme.
I guess that's a whole new refactoring issue as it didn't work before also. And we're just adding variants and properties in this one. |
@simeonoff should I log separate issues for this? |
Test with this theming package
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)