-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks #15397
Open
pmoleri
wants to merge
12
commits into
master
Choose a base branch
from
pmoleri/memory-leak-fixing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix memory leaks #15397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ee8fa3
to
abd57c1
Compare
c19c10e
to
2cadfa8
Compare
kdinev
requested changes
Feb 27, 2025
projects/igniteui-angular/src/lib/directives/button/button.directive.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/directives/scroll-inertia/scroll_inertia.directive.spec.ts
Outdated
Show resolved
Hide resolved
bf8cc4d
to
082924f
Compare
kdinev
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
button
button-group
📆 calendar
📆 month-picker
🎠 carousel
drag-drop
grid
overlay
stepper
tabs
🧪 ci: tests
version: 19.1.x
❌ status: awaiting-test
PRs awaiting manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several memory leaks
Addressed issues:
.bind()
in-place.createComponent()
ViewContainerRef.createComponent()
but then detached from it.Leak detection
Add leaks detection to the
configureTestSuite()
.If chrome is started with
--js-flags="--expose-gc"
it will track all created fixtures and perform agc()
at the end of the suite and it will report any leaked instances in memory.Also, it's performing the
moduleRef.destroy()
for all created modules that was missing before.The leak detection is opt-in for every suite because there are many existing issues and it may also report false positives for example:
beforeEach()
but it's not cleaned upafterEach()
Not all leaks will be detected. For example a component retained by a root service, in the lifecycle of the test it will be disposed but in a real app lifecycle this should be considered a leak.
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)