Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test errors #1379

Merged
merged 10 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "igniteui-cli",
"version": "14.3.14-beta.10",
"version": "14.3.14-beta.12",
"description": "CLI tool for creating Ignite UI projects",
"keywords": [
"CLI",
Expand Down Expand Up @@ -76,8 +76,8 @@
"all": true
},
"dependencies": {
"@igniteui/angular-templates": "~19.0.14314-beta.10",
"@igniteui/cli-core": "~14.3.14-beta.10",
"@igniteui/angular-templates": "~19.0.14314-beta.12",
"@igniteui/cli-core": "~14.3.14-beta.12",
"@inquirer/prompts": "^5.4.0",
"@types/yargs": "^17.0.33",
"chalk": "^5.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/cli-core",
"version": "14.3.14-beta.10",
"version": "14.3.14-beta.12",
"description": "Base types and functionality for Ignite UI CLI",
"repository": {
"type": "git",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- run: npm i # replace with 'npm ci' after committing lock file from first install
- run: npm run lint
- run: npm run build
- run: npm run test -- --watch=false --browsers ChromeHeadless
- run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly sure if we should add the flag here as this will also add it for all generated project. This may not be ideal if its sole purpose is to allow the automation on generated apps to run properly. It does not seem to be needed when publishing to GitHub and running the CI - link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it form the yml files and added it to the package.json files

Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- run: npm i # replace with 'npm ci' after committing lock file from first install
- run: npm run lint
- run: npm run build
- run: npm run test -- --watch=false --browsers ChromeHeadless
- run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- run: npm i # replace with 'npm ci' after committing lock file from first install
- run: npm run lint
- run: npm run build
- run: npm run test -- --watch=false --browsers ChromeHeadless
- run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- run: npm i # replace with 'npm ci' after committing lock file from first install
- run: npm run lint
- run: npm run build
- run: npm run test -- --watch=false --browsers ChromeHeadless
- run: NODE_OPTIONS="--max-old-space-size=6000" npm run test -- --watch=false --browsers ChromeHeadless
4 changes: 2 additions & 2 deletions packages/igx-templates/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/angular-templates",
"version": "19.0.14314-beta.10",
"version": "19.0.14314-beta.12",
"description": "Templates for Ignite UI for Angular projects and components",
"repository": {
"type": "git",
Expand All @@ -12,7 +12,7 @@
"author": "Infragistics",
"license": "MIT",
"dependencies": {
"@igniteui/cli-core": "~14.3.14-beta.10",
"@igniteui/cli-core": "~14.3.14-beta.12",
"typescript": "~5.5.4"
}
}
6 changes: 3 additions & 3 deletions packages/ng-schematics/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/angular-schematics",
"version": "19.0.14314-beta.10",
"version": "19.0.14314-beta.12",
"description": "Ignite UI for Angular Schematics for ng new and ng generate",
"repository": {
"type": "git",
Expand All @@ -20,8 +20,8 @@
"dependencies": {
"@angular-devkit/core": "^19.0.0",
"@angular-devkit/schematics": "^19.0.0",
"@igniteui/angular-templates": "~19.0.14314-beta.10",
"@igniteui/cli-core": "~14.3.14-beta.10",
"@igniteui/angular-templates": "~19.0.14314-beta.12",
"@igniteui/cli-core": "~14.3.14-beta.12",
"@schematics/angular": "~19.0.0",
"minimatch": "^10.0.1",
"rxjs": "^7.8.1"
Expand Down
Loading