Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combo / Input / Select]: Background colors in some states don't match Figma (box design) in Material Dark #385

Closed
andiesm813 opened this issue Jan 29, 2025 · 2 comments · Fixed by #386, IgniteUI/igniteui-angular#15375 or IgniteUI/igniteui-webcomponents#1580
Assignees
Labels
🐛 bug Something isn't working

Comments

@andiesm813
Copy link

Description

This is happening for MATERIAL DARK theme when the components are used in BOX style.
The following BACKGROUND colors in these states in Angular / WebComponent, do not match the Figma design:

  • Idle
  • Idle & Hover
  • Filled
  • Filled & Hover
  • Focused

Implemented Components

Image

Figma Design

Image

Expected result

  1. The idle / Idle & Hover / Filled / Filled & Hover background colors should match the Figma backgrounds.
  2. The Focused background color should match the Figma

Image

@andiesm813 andiesm813 added the 🐛 bug Something isn't working label Jan 29, 2025
@yradoeva
Copy link

The implementation should follow the Figma design kit, with 2 exceptions:

  • Combo in focused state
    background color should be dark grays.300 with 38% opacity
    toggle button background should be dark grays.200
Image
  • Select in focused state
    background color should be dark grays.300 with 38% opacity
    toggle button background should be dark grays.200
Image

This way all input components are aligned in focused state.

(Will be fixed soon in the design kit.)

@andiesm813
Copy link
Author

Thanks @yradoeva Dani! I was going to clarify this too, after reading the comments on Figma. Thank you for taking the time to do it ;)

@simeonoff simeonoff changed the title Combo / Input / Selec (box style)t: Background Colors in some states don't match Figma (design) in Material Dark [Combo / Input / Select]: Background colors in some states don't match Figma (box design) in Material Dark Feb 4, 2025
@simeonoff simeonoff assigned SisIvanova and unassigned simeonoff Feb 12, 2025
@simeonoff simeonoff transferred this issue from IgniteUI/igniteui-angular Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment