Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combo/select): toggle button styles #15375

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

fix(combo/select): toggle button styles #15375

wants to merge 11 commits into from

Conversation

SisIvanova
Copy link
Collaborator

Related to IgniteUI/igniteui-theming#385

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova requested a review from didimmova February 17, 2025 20:07
@SisIvanova SisIvanova linked an issue Feb 19, 2025 that may be closed by this pull request
[Combo / Input / Select]: Background colors in some states don't match Figma (box design) in Material Dark IgniteUI/igniteui-theming#385
Closed
@SisIvanova SisIvanova changed the title fix(combo): material theme hover state issue fix(combo/select): toggle button styles Feb 19, 2025
@didimmova didimmova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 19, 2025
didimmova
didimmova previously approved these changes Feb 19, 2025
View reviewed changes
@yradoeva

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didimmova didimmova didimmova left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@didimmova didimmova

@yradoeva yradoeva

Labels
combo design: verified input material-theme select Select component version: 19.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Combo / Input / Select]: Background colors in some states don't match Figma (box design) in Material Dark
5 participants
@SisIvanova @yradoeva @didimmova @kdinev @simeonoff