Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force rules on boot despite crash #143

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Force rules on boot despite crash #143

merged 7 commits into from
Jan 10, 2025

Conversation

CurlyMoo
Copy link

@CurlyMoo CurlyMoo commented Nov 3, 2024

@CurlyMoo CurlyMoo mentioned this pull request Nov 3, 2024
Open
@stumbaumr
Copy link

stumbaumr commented Nov 3, 2024 •
edited
Loading

Actions really need fixing now...

Like I stated here... #136 (comment)

@geduxas
Copy link

geduxas commented Nov 3, 2024

Actions really need fixing now...

Like I stated here... #136 (comment)

I fixed actions in my PR..

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 3, 2024

I fixed actions in my PR..

Are those fixes already accepted in the HeishaMon main branch?

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 3, 2024

@stumbaumr the action is fixed and build is done.

@stumbaumr
Copy link

I updated to your build and the /settings just hangs...
grafik

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 4, 2024

@stumbaumr can you check if the settings json does work?
http://192.168.178.151/getsettings

@stumbaumr
Copy link

stumbaumr commented Nov 4, 2024 •
edited
Loading

There is indeed a bug in the JSON output...
grafik
..."hotspot":1,"listenonly":0,"force_rules"0,"listenmqtt":0,"mqtt_topic_listen":"master_panasonic_heat_pump",...

A : is missing after "force_rules"

@CurlyMoo
Copy link
Author

CurlyMoo commented Nov 4, 2024

Fixed

@stumbaumr
Copy link

Works and I activated the checkbox. So will have to see when there is another reboot...

@stumbaumr
Copy link

Seems to work properly. @IgorYbema , I think this can be merged.

@stumbaumr
Copy link

@McMagellan , have tried this as well? Is it working for you?

@McMagellan
Copy link

My experience is this:
I have been using HeishamonV5 with the original firmware 3.8 since it was delivered last week.
I couldn't start Heishamon because the necessary changes in the settings caused the settings-window to freeze.
I use an old laptop with Win10 and Firefox as the browser, which I used just as easily with Heishamon V4.
After I used Firefox in private mode instead of the normal browser mode, the settings could be loaded here without any problems.

I haven't installed any new firmware since then and this behavior still occurs.

@stumbaumr
Copy link

Is the PR merge coming? Or what is missing?

@stumbaumr
Copy link

@IgorYbema , could you kindly merge this too, please. I can not test newer builds without this…

@IgorYbema IgorYbema changed the base branch from main to 3.9b January 9, 2025 16:00
@IgorYbema IgorYbema merged commit aaa59db into IgorYbema:3.9b Jan 10, 2025
1 check passed
IgorYbema added a commit that referenced this pull request Jan 14, 2025
@IgorYbema
Squashed commit of the following:
4fae7ea 
commit 38c7996
Author: IgorYbema <[email protected]>
Date:   Tue Jan 14 08:03:44 2025 +0100

    Websocket data refresh (#151)

    Add realtime refresh of data in webgui using websocket

commit 7ca46cc
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 20:03:39 2025 +0100

    remove heatpump model decoding

commit 7cc4c44
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 14:32:18 2025 +0100

    Update MQTT-Topics.md

commit 99f9a89
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 14:28:13 2025 +0100

    Update MQTT-Topics.md

commit 2103c31
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 10:47:49 2025 +0100

    some fixes

commit d27a1b4
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 10:42:06 2025 +0100

    some more bivalent changes

commit 85e688e
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 10:32:17 2025 +0100

    remove gpio16 control

commit bb92e3b
Author: IgorYbema <[email protected]>
Date:   Sun Jan 12 10:18:22 2025 +0100

    gpio readme update

commit 0368f8d
Author: IgorYbema <[email protected]>
Date:   Sat Jan 11 20:22:37 2025 +0100

    fix for stats

commit 2eee519
Author: IgorYbema <[email protected]>
Date:   Sat Jan 11 16:45:37 2025 +0100

    now better esp32 wifi reconnect

commit ba544b3
Author: IgorYbema <[email protected]>
Date:   Sat Jan 11 16:45:24 2025 +0100

    add option to ESP32 html code def

commit 9f846df
Author: krzbor <[email protected]>
Date:   Sat Nov 30 20:35:00 2024 +0100

    Asynchronous 1-wire reading

    Currently, 1-wire is read synchronously, which means the program is paused for up to 750ms. During this pause, a yield is called, ensuring that WiFi works correctly. However, other issues may arise, such as UART read buffer overflow.
    I have modified the code so that everything operates asynchronously.
    The previous solution to this problem contained a bug:
      if ((DALLASASYNC) && ((unsigned long)(millis() - dallasTimer) > ((1000 * dallasTimerWait) - 1000)) ) {
        DS18B20.requestTemperatures(); // get temperatures for next run 1 second before getting the temperatures (async)
      }
    The author assumed the code would execute only once, while in reality, it was executed multiple times per second before the reading.

    Correction of the comment for DALLASASYNC

commit c6c4d06
Author: IgorYbema <[email protected]>
Date:   Sat Jan 11 10:00:22 2025 +0100

    update bivalent code

    update bivalent code

commit 4de83c9
Merge: fc3d1cb 3451384
Author: IgorYbema <[email protected]>
Date:   Fri Jan 10 21:25:37 2025 +0100

    Merge branch '3.9b' of https://github.com/IgorYbema/HeishaMon into 3.9b

commit fc3d1cb
Author: IgorYbema <[email protected]>
Date:   Fri Jan 10 21:25:15 2025 +0100

    small fix

commit 3451384
Author: IgorYbema <[email protected]>
Date:   Fri Jan 10 21:21:46 2025 +0100

    sync up (#148)

    * remove unused dependencies

    * remove unused dependencies

    * improve note

    * Delete platformio.ini

    * Update LIBSUSED.md

    * Update decode.h

    * Update HeatPumpType.md

    * Update OptionalPCB.md

    * Update OptionalPCB.md

    * add bivalent heating

    * add bivalent heating

    * add bivalent heating

    edit heat pump to match my id,
    add  mixing valve opening

    * Update decode.h

    * fix model count

    * added more switch options to bivalent settings because of homeassistant-aquara plugin

    * Add stale action to autoclose old issues and PR's

    * fix: removed deprecated payload_template from yaml

    Update heishamon.yaml to work with version 2025.2.0

    * style(integrations): Fix indentation and remove trailing spaces in HASS

    * When initializing the memory, the parameters for the memset() function were swapped and the memory was not initialized.

    (the compiler warnings had pointed this out)

    * Update README.md

    * Update HeatPumpType.md

    * add KIT-WC09L3E5 Update HeatPumpType.md

    |50 | E2 D5 0C 67 00 83 92 0C 27 98 | WH-ADC0509L3E5AN | WH-WDG05LE5 | KIT-WC09L3E5 | 5 | 1ph | HP - split L-series 3kW elec heating - AN |

    * add KIT-WC09L3E5 Update decode.h

    |50 | E2 D5 0C 67 00 83 92 0C 27 98 | WH-ADC0509L3E5AN | WH-WDG05LE5 | KIT-WC09L3E5 | 5 | 1ph | HP - split L-series 3kW elec heating - AN |

    refer to Egyras#614

    * changed string representation of number to the to 52 Update decode.h

    "52", //string representation of number of known models (last model number + 1)

    * change to right number 51 Update HeatPumpType.md

    string representation of number 51 instead of 50

    * added new model combination 52 Update HeatPumpType.md

    |52 | E2 D5 0C 67 00 83 92 0C 27 98 | WH-SDC0509L3E5 | WH-WDG05LE5 | KIT-WC09L3E5 | 5 | 1ph | HP - split L-series 3kW elec heating |

    * add correct byte value for Model combination 52 Update HeatPumpType.md

    E2 D5 0B 34 99 83 92 0C 27 98

    * add model combination 52 Update decode.h

    WH-SDC0509L3E5

    E2 D5 0B 34 99 83 92 0C 27 98

    ---------

    Co-authored-by: Egyras <[email protected]>
    Co-authored-by: mi-hol <[email protected]>
    Co-authored-by: HighlyCompressedAir <[email protected]>
    Co-authored-by: Gosun <[email protected]>
    Co-authored-by: geduxas <[email protected]>
    Co-authored-by: Krilo_89 <[email protected]>
    Co-authored-by: Alexander Gil <[email protected]>
    Co-authored-by: Reichelt <[email protected]>
    Co-authored-by: thecem <[email protected]>

commit aba49b6
Merge: e48a4fb 47b4855
Author: IgorYbema <[email protected]>
Date:   Fri Jan 10 21:19:42 2025 +0100

    Merge branch '3.9b' of https://github.com/IgorYbema/HeishaMon into 3.9b

commit 47b4855
Author: CurlyMoo <[email protected]>
Date:   Fri Jan 10 19:21:38 2025 +0100

    Add GPIO function in rules to control GPIO's (#146)

    * Update README.md

    * Update HeatPumpType.md

    * Add GPIO function to control GPIO's

    ---------

    Co-authored-by: IgorYbema <[email protected]>

commit 95a863f
Author: CurlyMoo <[email protected]>
Date:   Fri Jan 10 19:21:14 2025 +0100

    Allow returning TOP with string values (#145)

    * Update README.md

    * Update HeatPumpType.md

    * Allow returning TOP with string values

    * Update rules library version

    ---------

    Co-authored-by: IgorYbema <[email protected]>

commit 0b02f88
Author: CurlyMoo <[email protected]>
Date:   Fri Jan 10 19:20:54 2025 +0100

    Update rules library version (#144)

    * Update README.md

    * Update rules library version

    * Update github workflow

    * Fix for calling events with variable parameters

    * Restore defines

    * Restore defines 2

    * Warn when too many conditions are stacked

    ---------

    Co-authored-by: IgorYbema <[email protected]>

commit a342884
Author: geduxas <[email protected]>
Date:   Fri Jan 10 20:19:51 2025 +0200

    Add new topics (#141)

    * Add new topics

    * Update README.md

    * Mixed with zones

    ---------

    Co-authored-by: IgorYbema <[email protected]>

commit aaa59db
Author: CurlyMoo <[email protected]>
Date:   Fri Jan 10 19:18:05 2025 +0100

    Force rules on boot despite crash (#143)

    * Allow forcing rules on boot despite crash

    * Fix wrong condition

    * Replace arrow with dot

    * Update upload artifact version

    * Fix wrong condition

    * Fix string length

commit e48a4fb
Author: IgorYbema <[email protected]>
Date:   Thu Jan 9 20:39:36 2025 +0100

    maybe better ESP32 wifi reconnect

commit d05c827
Author: CurlyMoo <[email protected]>
Date:   Mon Dec 16 19:25:29 2024 +0100

    Fix TSTRING parsing in conditionals (#139)

commit bbb0a70
Author: Grégoire Seux <[email protected]>
Date:   Mon Dec 16 19:24:03 2024 +0100

    Expose board type via mqtt (#140)

    * Expose board type via mqtt

commit 4e441c4
Author: IgorYbema <[email protected]>
Date:   Mon Dec 9 19:37:38 2024 +0100

    remove S0 GPIO settings

commit c3b20c6
Author: IgorYbema <[email protected]>
Date:   Wed Nov 27 19:23:39 2024 +0100

    update github workflow

commit de55d9d
Author: IgorYbema <[email protected]>
Date:   Sun Nov 24 20:19:57 2024 +0100

    move all channel scan to esp32 def only

commit c74e08b
Author: IgorYbema <[email protected]>
Date:   Sun Nov 24 10:57:42 2024 +0100

    add wifi all scan esp32 and revert log changes

commit 771297c
Author: IgorYbema <[email protected]>
Date:   Fri Nov 1 17:54:37 2024 +0100

    switch workflow to v4 artifacts upload

commit 40f5f18
Author: IgorYbema <[email protected]>
Date:   Fri Nov 1 17:52:28 2024 +0100

    change xtop detect method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CurlyMoo @stumbaumr @geduxas @McMagellan @IgorYbema