Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth2 client #113

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update OAuth2 client #113

merged 1 commit into from
Feb 10, 2025

Conversation

brianhelba
Copy link
Member

The library @isic/client is being retired, in favor of directly using the @resonant/oauth-client library which it depended on.

@brianhelba brianhelba requested a review from volishevko February 3, 2025 18:23
@brianhelba
Copy link
Member Author

@volishevko Please take a look. We need to update this library in order to make some internal changes on the server.

@volishevko
Copy link
Contributor

volishevko commented Feb 4, 2025

@volishevko Please take a look. We need to update this library in order to make some internal changes on the server.

@brianhelba, There is an error on logout.
oauth-client.isic-display-ui.pages.dev-1738675378742.log

Copy link

cloudflare-workers-and-pages bot commented Feb 4, 2025

Deploying isic-display-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2976694
Status: ✅  Deploy successful!
Preview URL: https://86af8d44.isic-display-ui.pages.dev
Branch Preview URL: https://oauth-client.isic-display-ui.pages.dev

View logs

@brianhelba
Copy link
Member Author

@volishevko Good find, thanks. I've fixed the error upstream and updated this to use a newer version of the library.

Let me know if it's working for you now too.

Copy link
Contributor

@volishevko volishevko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Approved.

The library "@isic/client" is being retired, in favor of directly using the
"@resonant/oauth-client" library which it depended on.
@brianhelba brianhelba merged commit ad9b9f7 into master Feb 10, 2025
3 checks passed
@brianhelba brianhelba deleted the oauth-client branch February 10, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants