-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update container README links and fix Apptainer push #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW apparently the bash version on my latest macOS is still too old to support this. 😔
.github/workflows/deploy-image.yml
Outdated
@@ -77,5 +77,9 @@ jobs: | |||
- name: Build an apptainer image | |||
run: apptainer build --build-arg PYBIOCLIP_VERSION=${{ steps.meta.outputs.version }} apptainer.sif apptainer.def | |||
|
|||
- name: create lowercase image name | |||
id: lowercase | |||
run: echo "LC_IMAGE_NAME=${IMAGE_NAME,,}" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this needs to be a separate step? I.e., if you can do ${IMAGE_NAME,,}
here, shouldn't that also work in the run
command in the following step, folding it in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Initially I had issues with the nested escaping syntax, but giving it another shot I found syntax that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
On the Apptainer package, it says to do the following to install: docker pull ghcr.io/imageomics/pybioclip-sif:1.0.0 Is there a way to change that to a custom command? The closest thing seems to be the description label, but it doesn't appear that this would remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thompsonmj I haven't been able to find anything to change that page. |
Adds links to README for Docker and Apptainer instructions.
Fixes the Apptainer push step in CI.
Fixes #27
Fixes #43