Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binning to custom label prediction #53

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add binning to custom label prediction #53

merged 1 commit into from
Oct 16, 2024

Conversation

johnbradley
Copy link
Collaborator

Allow users to group custom label predictions into bins.

Fixes #29

Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good AFAICT! I think there's a bit of confusion about which arguments are mutually exclusive, tried to fix those (see inline edit suggestions).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/bioclip/__main__.py Outdated Show resolved Hide resolved
Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting update. Just a couple small notes.

src/bioclip/__main__.py Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
Allow users to group custom label predictions into bins.

Fixes #29

Co-authored-by: Hilmar Lapp <[email protected]>
Co-authored-by: Elizabeth Campolongo <[email protected]>
@johnbradley johnbradley merged commit d8035ef into main Oct 16, 2024
1 check passed
@johnbradley johnbradley deleted the 29-custom-bins branch October 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow providing custom bins for summing scores
3 participants