-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy, polars and pandas as extra dependencies #97
Conversation
@@ -32,7 +32,7 @@ jobs: | |||
poetry-version: 1.8.3 | |||
|
|||
- name: Install dependencies | |||
run: poetry install --with dev | |||
run: poetry install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So poetry will install optional dependencies ("extras") by default, but if pip-installing, you'd have to specify them explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Now, if you do NOT want them, you do, for example, poetry install --without dev
, but the default position is install all dependencies. As mentioned above, poetry is for developers, not for end users, and they will typically want all the pedendencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. Poetry installs all groups by default except for extras
and those marked as optional. Previously, the dev
and docs
groups were marked as optional, but this PR changes that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I assume this works with the pip install pycsvy[pandas]
notation because it follows the docs. Hard to work out how to test it though.
I guess you can create a wheel with |
Just checked what I said and it works as planned: |
# Conflicts: # poetry.lock
Such that, eventually, the chosen engine can be installed with
pip install pycsvy[pandas]
, for example.It also removes the
optional
dependencies for the groups since using poetry directly is meant for developers and they will want, normally, all the dependencies.Close #90