Fix the 'Illegal Entity Teleport' issue #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, the issue was caused by the fact that the entity was being teleported in the
EntityPortalEnterEvent, and then whenEntityPortalEventis called, the entity is in the middle of a teleportation, which the game may not like, or something like that.So to fix that I found a way to prevent the default
EntityPortalEventfrom being called by setting the entity's portal cooldown, and to make it so the event may still be used, I called anotherEntityPortalEvent.With that in place, if someone wants to cancel a teleportation or change the destination, it can now be easily done.