Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize ArduinoCore-API update #323

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Conversation

LinjingZhang
Copy link
Collaborator

@LinjingZhang LinjingZhang commented Jan 24, 2025

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
✅ Include ArduinoCore API as submodule in XMC4Arduino (refer to psoc)
✅ Setup clean development env (refer to psoc and megaavr)
✅ Update readTheDocs (refer to psoc)

Related Issue
https://jirard.intra.infineon.com/browse/DESMAKERS-4256
https://jirard.intra.infineon.com/browse/DESMAKERS-4281

Context

@LinjingZhang LinjingZhang requested review from ederjc and jaenrig-ifx and removed request for ederjc January 24, 2025 15:59
Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 👍

@@ -0,0 +1,57 @@
#!/bin/bash

# Check if Python and pip are installed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this script required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really :D just for the convenience of my own local builds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. I see a bit of a mix of installation, configuration... build. Not something for generic use, but personal.
Please remove it and keep it locally for you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry! I forget to push remote ...

@LinjingZhang LinjingZhang merged commit e7cbd08 into 4.0.0-pre-release Jan 28, 2025
5 of 15 checks passed
@LinjingZhang LinjingZhang deleted the core-api-update branch January 28, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants