Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query structured #41

Merged
merged 24 commits into from
Nov 8, 2023
Merged

feat: query structured #41

merged 24 commits into from
Nov 8, 2023

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Aug 30, 2023

Proposed Changes

Add structured query support

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (ced60ce) 86.30% compared to head (5c8c3eb) 77.17%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   86.30%   77.17%   -9.14%     
==========================================
  Files          13       14       +1     
  Lines         628      771     +143     
  Branches       96      110      +14     
==========================================
+ Hits          542      595      +53     
- Misses         38      120      +82     
- Partials       48       56       +8     
Files Coverage Δ
...in/java/com/influxdb/v3/client/InfluxDBClient.java 100.00% <ø> (ø)
...nfluxdb/v3/client/internal/InfluxDBClientImpl.java 80.46% <50.00%> (-11.03%) ⬇️
.../main/java/com/influxdb/v3/client/PointValues.java 43.24% <43.24%> (ø)
src/main/java/com/influxdb/v3/client/Point.java 73.96% <73.96%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sciator Sciator force-pushed the feat-query-structured branch from 68ba7b9 to 135c361 Compare November 3, 2023 08:20
@Sciator Sciator requested a review from bednar November 3, 2023 09:57
@Sciator Sciator marked this pull request as ready for review November 3, 2023 09:58
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sciator thanks for your PR.

Please add query to points into integration tests.

src/main/java/com/influxdb/v3/client/InfluxDBClient.java Outdated Show resolved Hide resolved
src/main/java/com/influxdb/v3/client/Point.java Outdated Show resolved Hide resolved
src/main/java/com/influxdb/v3/client/PointValues.java Outdated Show resolved Hide resolved
@Sciator Sciator force-pushed the feat-query-structured branch from f467b7a to 08b62ee Compare November 7, 2023 13:22
@Sciator Sciator force-pushed the feat-query-structured branch from 80c86c4 to 42dbd29 Compare November 7, 2023 15:45
@Sciator Sciator requested a review from bednar November 8, 2023 10:06
@Sciator Sciator force-pushed the feat-query-structured branch from cd6532d to b7ac548 Compare November 8, 2023 11:17
README.md Outdated Show resolved Hide resolved
@Sciator Sciator force-pushed the feat-query-structured branch from b7ac548 to 1afaf71 Compare November 8, 2023 11:20
@bednar bednar merged commit 948bc14 into main Nov 8, 2023
@bednar bednar deleted the feat-query-structured branch November 8, 2023 11:36
@bednar bednar added this to the 0.4.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants