Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Keep sortedName as lowercased #1225

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix: Keep sortedName as lowercased #1225

merged 2 commits into from
Jul 12, 2024

Conversation

Ambrdctr
Copy link
Contributor

@Ambrdctr Ambrdctr commented Jul 11, 2024 •
edited
Loading

Realm can't sort files correctly: issue.
Keep sortedName as lowercased to sort files alphabetically (and case insensitive).

adrien-coye
adrien-coye reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this code. I'm double-checking that this is what is expected for iOS and Android. Edit: Done

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adrien-coye
adrien-coye approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🙌

@Ambrdctr Ambrdctr merged commit d3c33b8 into master Jul 12, 2024
3 checks passed
@Ambrdctr Ambrdctr deleted the sort-files branch July 12, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ambrdctr @adrien-coye