Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve decoding of text files for preview #1300

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing with various files with broken encoding. Working well.
It looks like the work is done fully on the main thread. I'll suggest something in another PR.

@adrien-coye adrien-coye merged commit 7d9d7f0 into master Sep 24, 2024
3 checks passed
@adrien-coye adrien-coye deleted the fix-preview branch September 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants