Skip to content

Commit

Permalink
refactor(ThreadListToolbar): Use isCompactWindow
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippeWeidmann committed May 4, 2023
1 parent 36e8ff2 commit 9027fa4
Showing 1 changed file with 9 additions and 13 deletions.
22 changes: 9 additions & 13 deletions Mail/Views/Thread List/ThreadListView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ struct ThreadListView: View {

@LazyInjectService private var matomo: MatomoUtils

let isCompact: Bool

private var shouldDisplayEmptyView: Bool {
viewModel.folder.lastUpdate != nil && viewModel.sections.isEmpty && !viewModel.isLoadingPage
}
Expand All @@ -78,7 +76,6 @@ struct ThreadListView: View {
isCompact: isCompact))
_multipleSelectionViewModel =
StateObject(wrappedValue: ThreadListMultipleSelectionViewModel(mailboxManager: mailboxManager))
self.isCompact = isCompact

UITableViewCell.appearance().focusEffect = .none
}
Expand Down Expand Up @@ -177,8 +174,7 @@ struct ThreadListView: View {
isRefreshing = false
}
}
.modifier(ThreadListToolbar(isCompact: isCompact,
flushAlert: $flushAlert,
.modifier(ThreadListToolbar(flushAlert: $flushAlert,
viewModel: viewModel,
multipleSelectionViewModel: multipleSelectionViewModel) {
withAnimation(.default.speed(2)) {
Expand Down Expand Up @@ -249,20 +245,20 @@ struct ThreadListView: View {
}

private struct ThreadListToolbar: ViewModifier {
var isCompact: Bool
@LazyInjectService private var matomo: MatomoUtils

@Binding var flushAlert: FlushAlertState?
@Environment(\.isCompactWindow) var isCompactWindow

@ObservedObject var viewModel: ThreadListViewModel
@ObservedObject var multipleSelectionViewModel: ThreadListMultipleSelectionViewModel
@EnvironmentObject private var splitViewManager: SplitViewManager
@EnvironmentObject private var navigationDrawerState: NavigationDrawerState

@State private var isShowingSwitchAccount = false
@State private var multipleSelectionActionsTarget: ActionsTarget?

@EnvironmentObject var splitViewManager: SplitViewManager
@EnvironmentObject var navigationDrawerState: NavigationDrawerState
@Binding var flushAlert: FlushAlertState?

@LazyInjectService private var matomo: MatomoUtils
@ObservedObject var viewModel: ThreadListViewModel
@ObservedObject var multipleSelectionViewModel: ThreadListMultipleSelectionViewModel

var selectAll: () -> Void

Expand All @@ -278,7 +274,7 @@ private struct ThreadListToolbar: ViewModifier {
}
}
} else {
if isCompact {
if isCompactWindow {
Button {
matomo.track(eventWithCategory: .menuDrawer, name: "openByButton")
navigationDrawerState.open()
Expand Down

0 comments on commit 9027fa4

Please sign in to comment.