Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enchanter Extractor making tools indestructible. #1498

Open
wants to merge 8 commits into
base: 1.21
Choose a base branch
from

Conversation

Kanzaji
Copy link
Contributor

@Kanzaji Kanzaji commented Oct 14, 2024

Resolves #1491

This PR is meant to fix few different issues as well, but those fixes are in Titanium, so the PR with rest of the fixes is on there 😄
Titanium PR will resolve #1487 #1475 (Possibly #1473 😅)

Titanium PR InnovativeOnlineIndustries/Titanium#131

Additionally small change from deprecated finalizeSpawn usage to the EvenHooks call in Mechanidal Dirt
Reworked the PlantSowerTile to work with any of the bush blocks
Sadly requires a Duck Interface Mixin, but this is the most universal solution to the problem.
I think it's better solution than a hard-coded list of supported stuff 😅
Apparently removing the damage component from a tool makes it indestructible tool now!
Setting damage to 0 is done by mc itself, resulting in a un-used tool.
@Kanzaji
Copy link
Contributor Author

Kanzaji commented Oct 14, 2024

I have honestly no idea why github still thinks commits above are missing from the main branch :P

Part of the fix for the LockableInventory bug.
Fix EnderIO screwing up the dev env sometimes. (No idea why it did work few days ago?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant