Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the JS build in its full glory up to a logical error in the lookup API. Notes:
Right now, running the tests require performing the following manual steps:
Then, from the js/ subdirectory:
The copy is required because the wasm/js bindings live in two different places. Maybe there's a way to do this more easily with just hacl-packages, after a successful build of hacl-packages.
I could use help with the following things:
node index.js
to CI