Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Set Seeds as conntainer objects #4793

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ class ITK_TEMPLATE_EXPORT IsolatedConnectedImageFilter : public ImageToImageFilt
PrintSelf(std::ostream & os, Indent indent) const override;

/** Add seed point 1. This seed will be isolated from Seed2 (if possible).
* All pixels connected to this seed will be replaced with ReplaceValue. */
* All pixels connected to this seed will be replaced with ReplaceValue.
*
* \deprecated Please use SetSeeds1.
*/
void
AddSeed1(const IndexType & seed);

Expand All @@ -115,7 +118,7 @@ class ITK_TEMPLATE_EXPORT IsolatedConnectedImageFilter : public ImageToImageFilt
* This seed will be isolated from Seed2 (if possible). All pixels
* connected to this seed will be replaced with ReplaceValue.
*
* \deprecated Please use AddSeed1.
* \deprecated Please use SetSeeds1.
*/
void
SetSeed1(const IndexType & seed);
Expand All @@ -124,15 +127,18 @@ class ITK_TEMPLATE_EXPORT IsolatedConnectedImageFilter : public ImageToImageFilt
void
ClearSeeds1();

/** Add seed point 2. This seed will be isolated from Seed1 (if possible). */
/** Add seed point 2. This seed will be isolated from Seed1 (if possible).
*
* \deprecated Please use SetSeed2.
*/
void
AddSeed2(const IndexType & seed);

/** Set a single seed point 2.
*
* This seed will be isolated from Seed1 (if possible).
*
* \deprecated Please use AddSeed2.
* \deprecated Please use SetSeed2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should then say SetSeeds2.

*/
void
SetSeed2(const IndexType & seed);
Expand All @@ -142,10 +148,10 @@ class ITK_TEMPLATE_EXPORT IsolatedConnectedImageFilter : public ImageToImageFilt
ClearSeeds2();

/** Method to access seed container */
virtual const SeedsContainerType &
GetSeeds1() const;
virtual const SeedsContainerType &
GetSeeds2() const;
itkSetMacro(Seeds1, SeedsContainerType);
itkGetConstReferenceMacro(Seeds1, SeedsContainerType);
itkSetMacro(Seeds2, SeedsContainerType);
itkGetConstReferenceMacro(Seeds2, SeedsContainerType);

/** Set/Get the limit on the lower threshold value. The default is
* the NonpositiveMin() for the InputPixelType. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,21 +147,6 @@ IsolatedConnectedImageFilter<TInputImage, TOutputImage>::ClearSeeds2()
}
}

template <typename TInputImage, typename TOutputImage>
auto
IsolatedConnectedImageFilter<TInputImage, TOutputImage>::GetSeeds1() const -> const SeedsContainerType &
{
itkDebugMacro("returning Seeds1");
return this->m_Seeds1;
}

template <typename TInputImage, typename TOutputImage>
auto
IsolatedConnectedImageFilter<TInputImage, TOutputImage>::GetSeeds2() const -> const SeedsContainerType &
{
itkDebugMacro("returning Seeds2");
return this->m_Seeds2;
}

template <typename TInputImage, typename TOutputImage>
void
Expand Down