Attempt to fix USE_SYSTEM_ITK #153
Conversation
There was a problem hiding this comment.
Thanks for the contribution @melrobin 💯. Have not tested.
An in-line comment and a few comments about the commit style:
-
Please, use the established commit prefixes to allow a clean and helpful commit history:
https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/blob/master/CONTRIBUTING.md#contributing-patches-with-git-and-githubConfiguring this pre-commit hook will be helpful for that prupose:
https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/blob/master/Utilities/Hooks/commit-msgThis involves splitting changes with different purposes (e.g. 5ef2d9a).
-
Also, provide a full description of the rationale behind the change in the commit message body. This allows people to know the existing failure or bug and how the fix addresses it.
Adopting these procedures allows maintainers and people that will read the commits afterwards have a clear view of what was changed, and what motivated such changes.
This also applies to the PR message when multiple commits are involved.
Although this certainly involves more work for the contributor, and potentially dealing with more PRs for maintainers, it is an effort that pays off. Additionally, this has the benefit that some PRs that do not require strict testing (e.g. typos) can be merged almost immediately, and reduces the number of essential and critical changes to review in PRs that require strict testing.
Thanks again. Keep up the good work.
| @@ -19,7 +19,7 @@ include(${ITK_USE_FILE}) | |||
|
|
|||
| if( NOT IS_DIRECTORY "${ITK_SOURCE_DIR}" ) | |||
| message(FATAL_ERROR "ITK source directory is not set :${ITK_SOURCE_DIR}:") | |||
| endif() | |||
| endif() | |||
There was a problem hiding this comment.
Please remove the trailing whitespace.
| @@ -12,7 +12,7 @@ Get output images only produced in BINARY_DIR. | |||
| -- Describe Modularization as part of a ITKv3->ITKv4 transition appendix | |||
| -- Update Acknowledgements | |||
| -- Test clean builds | |||
| -- Suport "USE_SYSTEM_ITK" | |||
| -- Support "USE_SYSTEM_ITK" | |||
There was a problem hiding this comment.
If this now works, it can be removed from this to do list.
| @@ -12,7 +12,7 @@ Get output images only produced in BINARY_DIR. | |||
| -- Describe Modularization as part of a ITKv3->ITKv4 transition appendix | |||
| -- Update Acknowledgements | |||
| -- Test clean builds | |||
There was a problem hiding this comment.
@jhlegarreta we should clean up this TODO, as many/most things have been done by now.
There was a problem hiding this comment.
@dzenanz I agree the list needs to be cleaned up, each item be checked, and maybe issues be opened instead of keeping this file. Not sure if I will have the bandwidth in the short-, mid-term to do this though.
There was a problem hiding this comment.
Turning the entire file into issues is a great idea! We don't have to address them soon.
With this commit I was able to get the ITK Software Guide to build with the setting USE_SYSTEM_ITK=ON.