fix/kubernetes-pod-status #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Singhal-06
changed the title
Test Results360 tests 352 ✅ 38m 45s ⏱️ Results for commit 9f75936. ♻️ This comment has been updated with latest results. |
fred-labs
requested changes
Oct 20, 2024
...cenario_execution_kubernetes/scenario_execution_kubernetes/kubernetes_wait_for_pod_status.py
Show resolved
Hide resolved
fmirus
requested changes
Oct 22, 2024
...cenario_execution_kubernetes/scenario_execution_kubernetes/kubernetes_wait_for_pod_status.py
Outdated
Show resolved
Hide resolved
fmirus
previously approved these changes
Oct 22, 2024
fred-labs
requested changes
Nov 11, 2024
| if not isinstance(status, tuple) or not isinstance(status[0], str): | ||
| raise ValueError("Status expected to be enum.") | ||
| self.expected_status = status[0] | ||
| self.regex = regex | ||
| self.current_state = KubernetesWaitForPodStatusState.MONITORING | ||
| self.is_pod = False | ||
| self.monitoring_thread = threading.Thread(target=self.watch_pods, daemon=True) |
There was a problem hiding this comment.
this creates a new thread for every execution. Instead please rework the previous solution
--> in update() when getting the last element from update_queue (line 58) , store the item in a member variable (e.g. self.current_state). This allows you to keep the state for another execution. Then you can rework the update() function:
- move the check within update() into a separate function.
- update() should look something like that afterwards:
if self.update_queue().empty():
if self.current_state is not None and check(self.current_state):
return SUCCESS
return RUNNING
else:
while not self.update_queue.empty():
self.current_state = self.update_queue.get()
if check(self.current_state):
return SUCCESS
return RUNNING
...cenario_execution_kubernetes/scenario_execution_kubernetes/kubernetes_wait_for_pod_status.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pod status action fails to detect the pod status.
Pull request checklist
make check) pass locallyPull request type
Current behavior
New behavior
How to test