Handle dpnp functions and tests to run on CUDA devices #2075

npolina4 · 2024-09-24T18:54:35Z

This PR suggests updating some function implementations and tests to run on CUDA devices
The PR includes:

Raise NotImplemetedError for unsupported functions
Create skipped_tests_cuda.tbl for unsupported functions
Skipped tests with a bug ticket for functions that should run on CUDA
Implement is_cuda_backend() and is_cuda_device() to determine that the object has a CUDA backend and that the tests run on CUDA

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you filing the PR as a draft?

dpnp/dpnp_iface.py

tests/test_indexing.py

dpnp/dpnp_iface.py

tests/third_party/cupy/core_tests/test_dlpack.py

tests/third_party/cupy/statistics_tests/test_meanvar.py

dpnp/dpnp_iface_indexing.py

coveralls · 2024-12-20T16:34:20Z

coverage: 70.842% (-0.1%) from 70.943%
when pulling 58b81a8 on tests_cuda
into 498e705 on master.

dpnp/tests/test_mathematical.py

dpnp/tests/test_usm_type.py

antonwolfy

I have only a minor comment. Overall LGTM.
Thank you @vlad-perevezentsev

github-actions · 2025-01-16T15:02:53Z

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_55 ran successfully.
Passed: 949
Failed: 0
Skipped: 51

This PR suggests updating some function implementations and tests to run on CUDA devices The PR includes: 1. Raise NotImplemetedError for unsupported functions 2. Create **skipped_tests_cuda.tbl** for unsupported functions 3. Skipped tests with a bug ticket for functions that should run on CUDA 4. Implement **is_cuda_backend()** and **is_cuda_device()** to determine that the object has a CUDA backend and that the tests run on CUDA --------- Co-authored-by: Vladislav Perevezentsev <[email protected]> 952a798

npolina4 added 2 commits September 20, 2024 10:32

Testing is adapted for cuda devices

b6bd08a

Apply fallback to numpy for all unsupported functions on cuda device.

5f1b083

ndgrigorian reviewed Sep 25, 2024

View reviewed changes

dpnp/dpnp_iface.py Outdated Show resolved Hide resolved

update tests

fe8fe11

antonwolfy reviewed Sep 26, 2024

View reviewed changes

dpnp/dpnp_iface.py Outdated Show resolved Hide resolved

dpnp/dpnp_iface.py Outdated Show resolved Hide resolved

Applied review comments

0c64722

npolina4 marked this pull request as ready for review September 26, 2024 20:32

npolina4 requested review from vlad-perevezentsev and vtavana as code owners September 26, 2024 20:32

antonwolfy reviewed Oct 16, 2024

View reviewed changes

tests/test_indexing.py Outdated Show resolved Hide resolved

npolina4 added 6 commits October 22, 2024 14:03

Merge branch 'master' into tests_cuda

4ad814c

Update test_indexing.py

6e2c3c7

Update test_solve.py

4e3c87c

Update test_histogram.py

94a418e

Update test_histogram.py

1461e81

Merge branch 'master' into tests_cuda

47f51e3

antonwolfy reviewed Oct 25, 2024

View reviewed changes

dpnp/dpnp_iface.py Outdated Show resolved Hide resolved

tests/third_party/cupy/core_tests/test_dlpack.py Outdated Show resolved Hide resolved

tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved

vlad-perevezentsev added 4 commits November 14, 2024 07:34

Merge commit '7bfe0c8eec481452dcdd07d99eaf01373769ab5b' into tests_cuda

2fca5f7

Update skipped_tests_cuda.tbl

519008e

Apply fallback to numpy for TestRational and test_copy_multigpu

a38949d

Address remarks

139c784

antonwolfy reviewed Nov 20, 2024

View reviewed changes

dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved

vlad-perevezentsev added 8 commits November 21, 2024 03:19

Merge master into tests_cuda

f7e3778

Merge master into tests_cuda

42f20fc

Use dpctl.select_default_device() in is_cuda_backend() func

351e12d

Raise NotImplementedError in unsupported functions on CUDA

590dbc8

Implement is_cuda_device() func for tests in helper.py

cc48533

Skipped tests for unsupported functions on CUDA

645c6d9

Update test_arithmetic.py

6f688fe

Handle TestSpacing to run on CUDA

b217cc5

vlad-perevezentsev added 4 commits December 11, 2024 06:08

Skip TestCond::test_nan on CUDA

a7985b3

Unskip linalg tests due to fix in gh-2212

70c9b0a

Create non-singular matrix in test_usm_type.py::test_cond

556c1a3

Update jira ticket number for qr issue

2931a2b

vlad-perevezentsev force-pushed the tests_cuda branch from 5db119c to 2931a2b Compare December 11, 2024 14:09

vlad-perevezentsev added 7 commits December 11, 2024 06:47

Fix fallback numpy logic in def modf

73f2ca0

Revert deleted fixtures for TestChoose

8da6027

Merge master into tests_cuda

e87174e

Merge master into tests_cuda

82f3a17

Merge master into tests_cuda

c83c062

Add cuda to list_of_backend_str in test_sycl_queue.py

6769469

Merge master into tests_cuda

1a3142f

vlad-perevezentsev added 4 commits January 10, 2025 06:52

Merge master into tests_cuda

2f2235f

Remove skip due to SAT-7588

f0ee02a

Update TestFftn::test_fftn

2427599

Pass self to is_cuda_backend

26275a7

antonwolfy reviewed Jan 14, 2025

View reviewed changes

dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved

antonwolfy reviewed Jan 14, 2025

View reviewed changes

dpnp/tests/test_usm_type.py Outdated Show resolved Hide resolved

vlad-perevezentsev added 3 commits January 14, 2025 05:40

Merge master into tests_cuda

773b177

Apply remarks

deb17ac

Merge master into tests_cuda

79be7d3

antonwolfy reviewed Jan 15, 2025

View reviewed changes

dpnp/tests/test_usm_type.py Outdated Show resolved Hide resolved

antonwolfy approved these changes Jan 15, 2025

View reviewed changes

Apply a minor comment

58b81a8

vlad-perevezentsev merged commit 952a798 into master Jan 17, 2025
57 of 59 checks passed

vlad-perevezentsev deleted the tests_cuda branch January 17, 2025 11:01

vlad-perevezentsev mentioned this pull request Jan 17, 2025

Workaround for dpnp.linalg.qr() to run on CUDA #2265

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle dpnp functions and tests to run on CUDA devices #2075

Handle dpnp functions and tests to run on CUDA devices #2075

npolina4 commented Sep 24, 2024 •

edited by vlad-perevezentsev

Loading

coveralls commented Dec 20, 2024 •

edited

Loading

antonwolfy left a comment

github-actions bot commented Jan 16, 2025

Handle dpnp functions and tests to run on CUDA devices #2075

Handle dpnp functions and tests to run on CUDA devices #2075

Conversation

npolina4 commented Sep 24, 2024 • edited by vlad-perevezentsev Loading

coveralls commented Dec 20, 2024 • edited Loading

antonwolfy left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025

npolina4 commented Sep 24, 2024 •

edited by vlad-perevezentsev

Loading

coveralls commented Dec 20, 2024 •

edited

Loading