-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integer datatypes and add types to tests #2097
Merged
AlexanderKalistratov
merged 13 commits into
IntelPython:extended_types_support
from
AlexanderKalistratov:extend_supported_types
Dec 11, 2024
Merged
Add integer datatypes and add types to tests #2097
AlexanderKalistratov
merged 13 commits into
IntelPython:extended_types_support
from
AlexanderKalistratov:extend_supported_types
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
requested review from
antonwolfy,
npolina4,
vlad-perevezentsev and
vtavana
as code owners
October 9, 2024 14:44
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
3 times, most recently
from
October 9, 2024 17:35
1ef0be5
to
8842fa6
Compare
antonwolfy
reviewed
Oct 21, 2024
antonwolfy
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the list of supported type in documentation, please check doc/reference/dtypes_table.rst
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
4 times, most recently
from
December 3, 2024 04:32
46c79d6
to
793a40b
Compare
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
from
December 3, 2024 05:07
793a40b
to
bb703b8
Compare
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
from
December 3, 2024 15:21
abe0d2b
to
fe0c542
Compare
antonwolfy
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AlexanderKalistratov, LGTM!
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
2 times, most recently
from
December 11, 2024 17:55
ba4f1c2
to
67244af
Compare
antonwolfy
reviewed
Dec 11, 2024
antonwolfy
reviewed
Dec 11, 2024
antonwolfy
reviewed
Dec 11, 2024
AlexanderKalistratov
force-pushed
the
extend_supported_types
branch
from
December 11, 2024 18:21
e808384
to
8ea4606
Compare
antonwolfy
approved these changes
Dec 11, 2024
AlexanderKalistratov
merged commit Dec 11, 2024
99dc6c2
into
IntelPython:extended_types_support
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int8
,int16
,uint8
-uint64
) to dpnp interface[u]byte
,ushort
,[u]longlong
[u]long
aliases as it is removed fromNumPy
(https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations)int
alias as it is depricate inNumPy
DPNP_TEST_ALL_INT_TYPES
to enable/disable these types in testsFailing dpnp tests: