Permit "same_kind" casting for element-wise in-place operators
#2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
in-place-element-wise-func-casting
branch
2 times, most recently
from
5cb5319 to
9a41bf9
Compare
antonwolfy
force-pushed
the
in-place-element-wise-func-casting
branch
from
ee5c848 to
86d5c69
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
AlexanderKalistratov
approved these changes
Jan 10, 2025
github-actions bot
added a commit
that referenced
this pull request
Jan 11, 2025
The PR proposes to permit `"same_kind"` casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of [PR#1827](IntelPython/dpctl#1827). It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from [RR#1447](IntelPython/dpctl#1447)). The PR removes a temporary workaround from `dpnp.wrap` which depends on the implemented changes. 3d02b6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to permit
"same_kind"casting for element-wise in-place operators. The implementation leverages on dpctl changes added in scope of PR#1827.It also adds callbacks to support in-place bit-wise operators (leverages on dpctl changes from RR#1447).
The PR removes a temporary workaround from
dpnp.wrapwhich depends on the implemented changes.