Implement extension for dpnp.choose
#2201
Open
+1,207
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
3 times, most recently
from
c42f2ae to
8793b54
Compare
|
Tests will need to be added in general, and especially to |
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
8793b54 to
e7f0a0b
Compare
antonwolfy
reviewed
Dec 10, 2024
antonwolfy
reviewed
Dec 11, 2024
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
904d629 to
70a85c3
Compare
antonwolfy
reviewed
Dec 12, 2024
antonwolfy
reviewed
Dec 12, 2024
antonwolfy
reviewed
Dec 13, 2024
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
ed84f7a to
7642045
Compare
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
7642045 to
efa7e1c
Compare
8 tasks
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
efa7e1c to
131308f
Compare
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
3 times, most recently
from
a54f420 to
0fb1fdf
Compare
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
3 times, most recently
from
925b7d8 to
dad41e3
Compare
Based on suggestions by @AlexanderKalistratov Create unique_ptr wraps a device allocation, which still needs to be manually freed after kernel run, but will be deallocated automatically during validation leading to launch
Removes need for accumulating a list of USM types and queues
Also corrects errors for unexpected dtype to TypeError to match NumPy
Logic now handles 0d inputs to _populate_choose_kernel_params to avoid dereferencing empty shape and strides of input arrays
Co-authored-by: Anton <[email protected]>
Fix spacing in choices type list Fix spacing in example arrays
py_choose now uses multiple functions to move host data for choose kernel parameters to the device
ndgrigorian
force-pushed
the
dedicated-choose-kernel
branch
from
6b81516 to
ce0e0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new SYCL kernel for
dpnp.choosein a new extension,_indexing_impl.chooseis an embarrassingly parallel copy operation, where the array to copy from is chosen from a list based on the index in the indices array.