Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dpnp.iterable function #2208

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add dpnp.iterable function #2208

merged 3 commits into from
Dec 4, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 3, 2024

There was __iter__ method of dpnp.ndarray implemented in scope of #2206.

While this PR proposes to add implementation of dpnp.iterable function which is intended to check if the object (including dpnp.ndarray) can be iterated over.
The implementation leverages on NumPy call, which is based on attempt to pass the object to iter function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Dec 3, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 3f737be into master Dec 4, 2024
46 of 48 checks passed
@antonwolfy antonwolfy deleted the impl-iterable branch December 4, 2024 19:19
github-actions bot added a commit that referenced this pull request Dec 4, 2024
There was `__iter__` method of dpnp.ndarray implemented in scope of
#2206.

While this PR proposes to add implementation of `dpnp.iterable` function
which is intended to check if the object (including dpnp.ndarray) can be
iterated over.
The implementation leverages on NumPy call, which is based on attempt to
pass the object to `iter` function. 3f737be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants