Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update third party tests for newly added integr dtypes (int8, int16, uint8-uint64) #2239

Merged
merged 7 commits into from
Jan 23, 2025
Merged

update third party tests for newly added integr dtypes (int8, int16, uint8-uint64) #2239

merged 7 commits into from
Jan 23, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Dec 17, 2024

In this PR, third party tests are update to pass with newly added integer dtypes (int8, int16, uint8, uint16, uint32, uint64).
This PR is in continuation of #2233.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2239/index.html

@vtavana vtavana force-pushed the fix-cupy-tests-for-new-dtypes branch from 30287e0 to 22041d8 Compare December 18, 2024 17:20
@vtavana vtavana marked this pull request as ready for review December 19, 2024 15:11
antonwolfy
antonwolfy approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM!

@vtavana vtavana merged commit bca57d5 into fix-test_product-for-new-dtypes Jan 23, 2025
4 of 38 checks passed
@vtavana vtavana deleted the fix-cupy-tests-for-new-dtypes branch January 23, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy