Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment file to GitHub workflows #2258

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Contributor

TBC

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 13, 2025
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2258/index.html

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 6 times, most recently from a2500eb to 7c1869c Compare January 13, 2025 21:07
NO_INTEL_CHANNELS: '-c dppy/label/dev -c conda-forge --override-channels'
# Install the latest oneAPI compiler to work around an issue
INSTALL_ONE_API: 'yes'
environment-file: 'environments/environment.yml'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is environment.yml missing?

Copy link
Contributor Author

@antonwolfy antonwolfy Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generating by the command:

conda-merge ${{ env.base-doc-env }} ${{ env.build-pkgs-env }} > ${{ env.environment-file }}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Do we need to hardcode python=3.12 dependency in base_duild_docs.yml ?

Taking into consideration that we can dynamically create environment files using conda-merge?

Or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file will be split later, because part of packages are common with coverage workflow.
The PR is work in progress still :)

In general, the python is pinned as 3.12, because cupy package doesn't support 3.13, i.e. max python version depends on cupy package and so I linked them there in one file.

Alternatively we can miss python in base_duild_docs.yml and to pass as option of conda-incubator/setup-miniconda step, but I preferred to do that through base_duild_docs.yml file.

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch 2 times, most recently from f6baa58 to 475291b Compare January 14, 2025 12:57
@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025

Coverage Status

coverage: 70.844%. remained the same
when pulling 469f633 on stabilize-public-ci-part-3
into 807179a on master.

@antonwolfy antonwolfy force-pushed the stabilize-public-ci-part-3 branch from 475291b to 469f633 Compare January 20, 2025 16:29
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2258/index.html

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_11 ran successfully.
Passed: 950
Failed: 0
Skipped: 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants