-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment file to GitHub workflows #2258
base: master
Are you sure you want to change the base?
Conversation
View rendered docs @ https://intelpython.github.io/dpnp/pull/2258/index.html |
a2500eb
to
7c1869c
Compare
NO_INTEL_CHANNELS: '-c dppy/label/dev -c conda-forge --override-channels' | ||
# Install the latest oneAPI compiler to work around an issue | ||
INSTALL_ONE_API: 'yes' | ||
environment-file: 'environments/environment.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is environment.yml
missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generating by the command:
conda-merge ${{ env.base-doc-env }} ${{ env.build-pkgs-env }} > ${{ env.environment-file }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Do we need to hardcode python=3.12
dependency in base_duild_docs.yml ?
Taking into consideration that we can dynamically create environment files using conda-merge
?
Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file will be split later, because part of packages are common with coverage
workflow.
The PR is work in progress still :)
In general, the python is pinned as 3.12, because cupy package doesn't support 3.13, i.e. max python version depends on cupy package and so I linked them there in one file.
Alternatively we can miss python in base_duild_docs.yml
and to pass as option of conda-incubator/setup-miniconda
step, but I preferred to do that through base_duild_docs.yml
file.
f6baa58
to
475291b
Compare
475291b
to
469f633
Compare
View rendered docs @ https://intelpython.github.io/dpnp/pull/2258/index.html |
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_11 ran successfully. |
TBC