Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dpnp.isdtype implementation #2274

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Add dpnp.isdtype implementation #2274

merged 4 commits into from
Jan 23, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 22, 2025

The PR proposes to implement dpnp.isdtype function.

The function is mandated according to python array API. The corresponding muted tests are enabled in python array API compliance scope.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.194% (+0.01%) from 71.181%
when pulling 8b8c9d5 on impl-isdtype
into 451c2b3 on master.

Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_19 ran successfully.
Passed: 957
Failed: 0
Skipped: 43

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d522480 into master Jan 23, 2025
59 of 63 checks passed
@antonwolfy antonwolfy deleted the impl-isdtype branch January 23, 2025 10:30
github-actions bot added a commit that referenced this pull request Jan 23, 2025
The PR proposes to implement `dpnp.isdtype` function.

The function is mandated according to python array API. The
corresponding muted tests are enabled in python array API compliance
scope. d522480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants