Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tests to improve coverage stats #2277

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Add new tests to improve coverage stats #2277

merged 6 commits into from
Jan 28, 2025

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR continues #2268 and #2272 and suggests adding a couple new tests to slightly improve code coverage stats

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jan 24, 2025
antonwolfy
antonwolfy reviewed Jan 24, 2025
View reviewed changes
dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved
dpnp/tests/test_mathematical.py Outdated Show resolved Hide resolved
dpnp/tests/test_utils.py Outdated Show resolved Hide resolved
dpnp/tests/test_utils.py Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2025 •
edited
Loading

Coverage Status

coverage: 71.316% (+0.01%) from 71.302%
when pulling b8c5025 on new_tests_coverage
into df307dd on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_4 ran successfully.
Passed: 957
Failed: 0
Skipped: 43

antonwolfy
antonwolfy approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vlad-perevezentsev

dpnp/tests/test_ndarray.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2277/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_14 ran successfully.
Passed: 966
Failed: 1
Skipped: 33

@vlad-perevezentsev vlad-perevezentsev merged commit c844b26 into master Jan 28, 2025
61 of 69 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the new_tests_coverage branch January 28, 2025 15:37
github-actions bot added a commit that referenced this pull request Jan 28, 2025
@github-actions
Add new tests to improve coverage stats (#2277)
c38e275 
This PR continues #2268 and #2272 and suggests adding a couple new tests
to slightly improve code coverage stats c844b26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @antonwolfy