Update third party tests to pass without fp64 aspect #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_11 ran successfully. |
antonwolfy
force-pushed
the
fix-third-party-tests-numpy-2.2
branch
from
d492948 to
509da7b
Compare
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2284/index.html |
|
Array API standard conformance tests for dpnp=0.17.0dev5=py312he4f9c94_17 ran successfully. |
vtavana
approved these changes
Jan 30, 2025
github-actions bot
added a commit
that referenced
this pull request
Jan 30, 2025
Some of third party tests are intended to run towards the latest NumPy, but previously it was run only in public CI on OpenCL CPU device. With the new `stable` workflow available in the internal CI, such scenario is also covered for L0 GPU device. Thus the tests has to consider dtype check of result based on fp64 aspect of the device (some of GPU does not provide it). The PR proposes to update the affected tests and to modify dtype check based on device capabilities where the result is allocating. 6e9d830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of third party tests are intended to run towards the latest NumPy, but previously it was run only in public CI on OpenCL CPU device.
With the new
stableworkflow available in the internal CI, such scenario is also covered for L0 GPU device.Thus the tests has to consider dtype check of result based on fp64 aspect of the device (some of GPU does not provide it).
The PR proposes to update the affected tests and to modify dtype check based on device capabilities where the result is allocating.