Control-U during character class creation resets bonus pool #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classic Daggerfall uses plain U key, but since in Daggerfall Unity the
class name input field always has focus, that key would add an U
character to the class name instead.
Remark: keyboard handling behaves a bit differently in the Unity Editor
and in the Standalone Player: standalone player filters out control
characters, while the editor does not, adding a "?" in the class name
when Control-U is pressed. They could be filtered explicitly:
diff --git a/Assets/Scripts/Game/UserInterface/TextBox.cs
b/Assets/Scripts/Game/UserInterface/TextBox.cs
index 9da458cef..6d660339f 100644
--- a/Assets/Scripts/Game/UserInterface/TextBox.cs
+++ b/Assets/Scripts/Game/UserInterface/TextBox.cs
@@ -453,6 +453,14 @@ namespace DaggerfallWorkshop.Game.UserInterface
}
}
}
+ else // !numeric
+ {
+ // Filter control characters
+ if ((int)character < 0x20)
+ {
+ return;
+ }
+ }
// For upper only, force everything to caps
if (upperOnly)
but it seems less risky to just be aware of this small problem happening
in the Editor only.
petchema
added
the
classic variance
KABoissonneault
requested changes
Oct 5, 2024
KABoissonneault
approved these changes
Oct 12, 2024
|
Rereading the PR title, now I understand how confusing it was ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic Daggerfall uses plain U key, but since in Daggerfall Unity the class name input field always has focus, that key would add an U character to the class name instead.
Remark: Under Linux, keyboard handling behaves a bit differently in the Unity Editor and in the Standalone Player: standalone player filters out control characters, while the editor does not, adding a "?" in the class name when Control-U is pressed. They could be filtered explicitly:
but it seems less risky to just be aware of this small problem happening in the Editor only.
(just tested that the problem doesn't occur under Windows).