Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the "protected internal" keywords from the DaggerfallTravelPopUp.EndPos setter. #2697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RedRoryOTheGlen
Copy link
Contributor

Allows mods to change the endPos of DaggerfallTravelPopUp.

Video of proof-of-concept fast travel encounter mod I was working on. If it decides to roll an encounter, it will change the destination of the travel in the DaggerfallTravelPopUp.OnPreFastTravel event. Nothing fancy. This threw me for a loop because it pretty much worked flawlessly as a virtual mod and only caused an error when building the DFMOD.

@KABoissonneault
Copy link
Collaborator

For the "works in editor, fails in dfmod" issue, you only need to remove the internal, which I'm fine with removing (I don't think it's a great C# feature when working with Unity). I'd rather not remove the protected unless you had some justification for it.

@RedRoryOTheGlen
Copy link
Contributor Author

image

I tried it with the EndPos setter as "protected" only and now even the DaggerfallTravelMapWindow set throws an error in the Editor

@KABoissonneault
Copy link
Collaborator

Okay I admit the protected internal has me surprised, this seems to work as just internal. Removing both is fine then, if even DFU uses it as if it were public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants