Add --topic-config to specify QoS by topic via a .js file
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves #1 |
|
Please consider to open a pull request upstream: https://github.com/RobotWebTools/ros2-web-bridge/pulls |
|
I think there are DDS vendor specific ways to overwrite the QoS settings in general or per topic using an xml file and by setting an environment variable (e.g. https://docs.ros.org/en/galactic/Tutorials/FastDDS-Configuration/FastDDS-Configuration.html). So this patch may not be required anymore. |
|
If we can solve it like this would be great! Getting our PR upstream, is probably harder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as in https://github.com/Intermodalics/im-vps-web/pull/174
We have another PR incoming solving another issue (related to managing subscribers with multiple clients), hence good to separate them as issues.